Ensure SocketStream recalculates the timeout on each read #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbabanin
requested changes
Jan 26, 2024
| try { | ||
| ByteBuf buffer = bufferProvider.getBuffer(numBytes); | ||
| try { | ||
| int totalBytesRead = 0; | ||
| byte[] bytes = buffer.array(); | ||
| while (totalBytesRead < buffer.limit()) { | ||
| int readTimeoutMS = (int) operationContext.getTimeoutContext().getReadTimeoutMS(); | ||
| if (readTimeoutMS > 0) { |
There was a problem hiding this comment.
It seems If the timeout has already expired, readTimeoutMS can be 0. In this case, if socket.setSoTimeout was previously set to 100ms, the socket timeout still remains at 100ms, leading to repeated 100ms blocks, which could exceed the intended timeout.
I suggest that getReadTimeoutMS should throw an exception if timeoutMs has already expired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5298